[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 09/28] virtio-net: mark VIRTIO_NET_F_GSO as legacy
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v3 09/28] virtio-net: mark VIRTIO_NET_F_GSO as legacy |
Date: |
Tue, 15 Nov 2016 21:21:22 +0200 |
virtio 1.0 spec says this is a legacy feature bit,
hide it from guests in modern mode.
Note: for cross-version migration compatibility,
we keep the bit set in host_features.
The result will be that a guest migrating cross-version
will see host features change under it.
As guests only seem to read it once, this should
not be an issue. Meanwhile, will work to fix guests to
ignore this bit in virtio1 mode, too.
Cc: address@hidden
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
---
hw/net/virtio-net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 20aa63e..b68c69d 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1942,6 +1942,7 @@ static void virtio_net_class_init(ObjectClass *klass,
void *data)
vdc->guest_notifier_pending = virtio_net_guest_notifier_pending;
vdc->load = virtio_net_load_device;
vdc->save = virtio_net_save_device;
+ vdc->legacy_features |= (0x1 << VIRTIO_NET_F_GSO);
}
static const TypeInfo virtio_net_info = {
--
MST
- [Qemu-devel] [PULL v3 00/28] virtio, vhost, pc, pci: documentation, fixes and cleanups, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 01/28] intel_iommu: fixing source id during IOTLB hash key calculation, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 02/28] virtio: rename virtqueue_discard to virtqueue_unpop, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 03/28] virtio: make virtqueue_alloc_element static, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 04/28] virtio-crypto: tag as not hotpluggable and migration, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 05/28] intel_iommu: fix several incorrect endianess and bit fields, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 06/28] intel_iommu: fix incorrect assert, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 07/28] acpi: fix DMAR device scope for IOAPIC, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 08/28] virtio: allow per-device-class legacy features, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 09/28] virtio-net: mark VIRTIO_NET_F_GSO as legacy,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v3 10/28] vhost: migration blocker only if shared log is used, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 11/28] qdev: hotplug: drop HotplugHandler.post_plug callback, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 12/28] nvdimm acpi: drop the lock of fit buffer, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 13/28] pc: memhp: move nvdimm hotplug out of memory hotplug, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 14/28] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 15/28] nvdimm acpi: clean up nvdimm_build_acpi, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 16/28] docs: improve the doc of Read FIT method, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 17/28] nvdimm acpi: rename nvdimm_plugged_device_list, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 18/28] nvdimm acpi: cleanup nvdimm_build_fit, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 19/28] nvdimm acpi: rename nvdimm_acpi_hotplug, Michael S. Tsirkin, 2016/11/15