[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent
From: |
Jike Song |
Subject: |
Re: [Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev |
Date: |
Tue, 15 Nov 2016 17:30:09 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
On 11/15/2016 04:11 PM, Kirti Wankhede wrote:
>
>
> On 11/15/2016 12:15 PM, Jike Song wrote:
>> On 11/14/2016 11:42 PM, Kirti Wankhede wrote:
>>> Add a notifier calback to parent's ops structure of mdev device so that per
>>> device notifer for vfio module is registered through vfio_mdev module.
>>>
>>> Signed-off-by: Kirti Wankhede <address@hidden>
>>> Signed-off-by: Neo Jia <address@hidden>
>>> Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637
>>> ---
>>> drivers/vfio/mdev/vfio_mdev.c | 19 +++++++++++++++++++
>>> include/linux/mdev.h | 9 +++++++++
>>> 2 files changed, 28 insertions(+)
>>>
>>> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
>>> index ffc36758cb84..1694b1635607 100644
>>> --- a/drivers/vfio/mdev/vfio_mdev.c
>>> +++ b/drivers/vfio/mdev/vfio_mdev.c
>>> @@ -24,6 +24,15 @@
>>> #define DRIVER_AUTHOR "NVIDIA Corporation"
>>> #define DRIVER_DESC "VFIO based driver for Mediated device"
>>>
>>> +static int vfio_mdev_notifier(struct notifier_block *nb, unsigned long
>>> action,
>>> + void *data)
>>> +{
>>> + struct mdev_device *mdev = container_of(nb, struct mdev_device, nb);
>>> + struct parent_device *parent = mdev->parent;
>>> +
>>> + return parent->ops->notifier(mdev, action, data);
>>> +}
>>> +
>>> static int vfio_mdev_open(void *device_data)
>>> {
>>> struct mdev_device *mdev = device_data;
>>> @@ -40,6 +49,11 @@ static int vfio_mdev_open(void *device_data)
>>> if (ret)
>>> module_put(THIS_MODULE);
>>>
>>> + if (likely(parent->ops->notifier)) {
>>> + mdev->nb.notifier_call = vfio_mdev_notifier;
>>> + if (vfio_register_notifier(&mdev->dev, &mdev->nb))
>>> + pr_err("Failed to register notifier for mdev\n");
>>> + }
>>
>> Hi Kirti,
>>
>> Could you please move the notifier registration before parent->ops->open()?
>> as you might know, I'm extending your vfio_register_notifier to also include
>> the attaching/detaching events of vfio_group and kvm. Basically if
>> vfio_group
>> not attached to any kvm instance, the parent->ops->open() should return
>> -ENODEV
>> to indicate the failure, but to know whether kvm is available in open(), the
>> notifier registration should be earlier.
>>
>
> Ok. That seem fine to me.
>
Thanks - and I guess it's also good to move unregister after ->release(),
so that a sequence of register-open-release-unregister guaranteed :)
--
Thanks,
Jike
- Re: [Qemu-devel] [PATCH v12 09/22] vfio iommu type1: Add task structure to vfio_dma, (continued)
[Qemu-devel] [PATCH v12 13/22] vfio: Introduce common function to add capabilities, Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 14/22] vfio_pci: Update vfio_pci to use vfio_info_add_capability(), Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare(), Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 16/22] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare(), Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 18/22] vfio: Define device_api strings, Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 17/22] vfio_platform: Updated to use vfio_set_irqs_validate_and_prepare(), Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 19/22] docs: Add Documentation for Mediated devices, Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 20/22] docs: Sysfs ABI for mediated device framework, Kirti Wankhede, 2016/11/14