Re: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support

[Stefan Weil]

On 11/14/16 09:21, Vincent Palatin wrote:
> On Sun, Nov 13, 2016 at 4:20 AM,  <address@hidden> wrote:
> > === OUTPUT BEGIN ===
> > fatal: unrecognized argument: --no-patch
> > Checking PATCH 1/5: ...
> > fatal: unrecognized argument: --no-patch
> > Checking PATCH 2/5: ...
> > fatal: unrecognized argument: --no-patch
> > Checking PATCH 3/5: ...
> > fatal: unrecognized argument: --no-patch
> > Checking PATCH 4/5: ...
> > fatal: unrecognized argument: --no-patch
> > Checking PATCH 5/5: ...
> > ERROR: spaces required around that '-' (ctx:WxV)
> > #158: FILE: cpus.c:1276:
> > +        if (SuspendThread(cpu->hThread) == (DWORD) -1) {
> >                                                     ^
> >
> > ERROR: spaces required around that '-' (ctx:WxV)
> > #176: FILE: cpus.c:1294:
> > +        if (ResumeThread(cpu->hThread) == (DWORD) -1) {
> >                                                    ^
>
> Apparently I missed this couple of warnings when I did my final checkpatch pass.
> At the same time, I have no idea how to solve this one, can anybody
> enlighten me ?
> Having a space on both sides of a unary minus doesn't seem what we want,
> so I imagine something else is wrong and confuse a bit checkpatch.pl.


(DWORK)(-1) works for checkpatch.pl.

I noticed a strange behaviour of checkpatch.pl:

If I run it on all of your five commits, it does not find any error.
If I run it only on the 5th commit, it shows the two errors like above.

Stefan