Re: [Qemu-devel] [PULL 0/9] Ide patches

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 0/9] Ide patches
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5e96eb8 ahci-test: add QMP tray test for ATAPI
5fd60af libqos/ahci: Add get_sense and test_ready
14049ed libqos/ahci: Add ATAPI tray macros
330e1d8 libqos/ahci: Support expected errors
d895cc8 libqtest: add qmp_eventwait_ref
12f6469 block-backend: Always notify on blk_eject
d1277ce ahci-test: test atapi read_cd with bcl, nb_sectors = 0
4cf7858 ahci-test: Create smaller test ISO images
5f77a05 atapi: classify read_cd as conditionally returning data

=== OUTPUT BEGIN ===
fatal: unrecognized argument: --no-patch
Checking PATCH 1/9: ...
ERROR: space prohibited after that open square bracket '['
#92: FILE: hw/ide/atapi.c:1324:
+    [ 0xbe ] = { cmd_read_cd,                       CHECK_READY | CONDDATA },

ERROR: space prohibited before that close square bracket ']'
#92: FILE: hw/ide/atapi.c:1324:
+    [ 0xbe ] = { cmd_read_cd,                       CHECK_READY | CONDDATA },

total: 2 errors, 0 warnings, 86 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

fatal: unrecognized argument: --no-patch
Checking PATCH 2/9: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 3/9: ...
WARNING: line over 80 characters
#169: FILE: tests/libqos/ahci.c:908:
+        fprintf(stderr, "The Libqos AHCI driver does not support the 
set_offset "

total: 0 errors, 1 warnings, 192 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
fatal: unrecognized argument: --no-patch
Checking PATCH 4/9: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 5/9: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 6/9: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 7/9: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 8/9: ...
ERROR: line over 90 characters
#121: FILE: tests/libqos/ahci.h:617:
+void ahci_atapi_test_ready(AHCIQState *ahci, uint8_t port, bool ready, uint8_t 
expected_sense);

total: 1 errors, 0 warnings, 101 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

fatal: unrecognized argument: --no-patch
Checking PATCH 9/9: ...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden