[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/6] qdev: fix use-after-free regression from becdfa0
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 4/6] qdev: fix use-after-free regression from becdfa00cfa |
Date: |
Thu, 10 Nov 2016 18:52:40 +0100 |
From: Marc-André Lureau <address@hidden>
Spotted by Coverity, CID 1365383.
Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/core/qdev-properties-system.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index c35f0f5..1b7ea50 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -200,18 +200,14 @@ static void set_chr(Object *obj, Visitor *v, const char
*name, void *opaque,
}
s = qemu_chr_find(str);
- g_free(str);
if (s == NULL) {
error_setg(errp, "Property '%s.%s' can't find value '%s'",
object_get_typename(obj), prop->name, str);
- return;
- }
-
- if (!qemu_chr_fe_init(be, s, errp)) {
+ } else if (!qemu_chr_fe_init(be, s, errp)) {
error_prepend(errp, "Property '%s.%s' can't take value '%s': ",
object_get_typename(obj), prop->name, str);
- return;
}
+ g_free(str);
}
static void release_chr(Object *obj, const char *name, void *opaque)
--
1.8.3.1
- [Qemu-devel] [PULL 0/6] QEMU patches for 2.8.0-rc0, Paolo Bonzini, 2016/11/10
- [Qemu-devel] [PULL 2/6] vl.c: move pidfile creation up the line, Paolo Bonzini, 2016/11/10
- [Qemu-devel] [PULL 3/6] target-i386/machine: fix migrate faile because of Hyper-V HV_X64_MSR_VP_RUNTIME, Paolo Bonzini, 2016/11/10
- [Qemu-devel] [PULL 1/6] target-i386: fix typo, Paolo Bonzini, 2016/11/10
- [Qemu-devel] [PULL 4/6] qdev: fix use-after-free regression from becdfa00cfa,
Paolo Bonzini <=
- [Qemu-devel] [PULL 6/6] nbd: Don't inf-loop on early EOF, Paolo Bonzini, 2016/11/10
- [Qemu-devel] [PULL 5/6] target-i386: document how x86 gdb_num_core_regs is computed., Paolo Bonzini, 2016/11/10
- Re: [Qemu-devel] [PULL 0/6] QEMU patches for 2.8.0-rc0, Stefan Hajnoczi, 2016/11/11