Re: [Qemu-devel] [PATCH v13 1/2] virtio-crypto: Add virtio crypto device specification

[Gonglei (Arei)]

> From: Cornelia Huck [mailto:address@hidden
> Sent: Wednesday, November 09, 2016 11:25 PM
> Subject: Re: [Qemu-devel] [PATCH v13 1/2] virtio-crypto: Add virtio crypto
> device specification
> 
> On Wed, 9 Nov 2016 01:11:20 +0000
> "Gonglei (Arei)" <address@hidden> wrote:
> 
> > Nope, Actually I kept those description here is because I wanted to 
> > represent
> each packet
> > Intuitionally, otherwise I don't know how to explain them only occupy one
> entry in desc table
> > by indirect table method. So I changed the code completely as Stefan's
> suggestion and
> > revised the spec a little.
> 
> I think you need to revise the spec a bit more :) IIUC, you should
> simply state that you use the indirect table method and not mention any
> guest physical addresses.
> 
Yes, will remove the gpa description stuff. Using indirect table is a method 
for high performance
and throughput, I'll mention it as a note. Pls see my another reply to Michael.

> > This just is a representative of the realization so that the people can 
> > easily
> understand what
> > the virtio crypto request's components. It isn't completely same with the
> code.
> > For virtio-scsi device, the struct virtio_scsi_req_cmd also used this way 
> > IIUR.
> 
> It seemes to have caused at least some confusion - perhaps you
> simplyfied too much?

Yes, I will. 

Thanks,
-Gonglei