[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit |
Date: |
Wed, 9 Nov 2016 17:40:05 +0100 |
On Mon, 7 Nov 2016 19:13:43 +0800
Xiao Guangrong <address@hidden> wrote:
> inline buf_size to refine the code a bit
>
> Suggested-by: Igor Mammedov <address@hidden>
> Signed-off-by: Xiao Guangrong <address@hidden>
> ---
> hw/acpi/nvdimm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Igor Mammedov <address@hidden>
>
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index f2c0659..148999e 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -1134,11 +1134,9 @@ static void nvdimm_build_fit(Aml *dev)
> aml_append(ifctx, aml_return(aml_buffer(0, NULL)));
> aml_append(method, ifctx);
>
> - aml_append(method, aml_store(aml_shiftleft(buf_size, aml_int(3)),
> - buf_size));
> aml_append(method, aml_create_field(buf,
> aml_int(4 * BITS_PER_BYTE), /* offset at byte
> 4.*/
> - buf_size, "BUFF"));
> + aml_shiftleft(buf_size, aml_int(3)), "BUFF"));
> aml_append(method, aml_return(aml_name("BUFF")));
> aml_append(dev, method);
>
- Re: [Qemu-devel] [PATCH 05/14] nvdimm acpi: clean up nvdimm_build_acpi, (continued)
- [Qemu-devel] [PATCH 07/14] nvdimm acpi: rename nvdimm_plugged_device_list, Xiao Guangrong, 2016/11/07
- [Qemu-devel] [PATCH 06/14] docs: improve the doc of Read FIT method, Xiao Guangrong, 2016/11/07
- [Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit, Xiao Guangrong, 2016/11/07
- [Qemu-devel] [PATCH 10/14] nvdimm acpi: define DSM return codes, Xiao Guangrong, 2016/11/07
- [Qemu-devel] [PATCH 09/14] nvdimm acpi: rename nvdimm_acpi_hotplug, Xiao Guangrong, 2016/11/07
- [Qemu-devel] [PATCH 12/14] nvdimm acpi: rename nvdimm_dsm_reserved_root, Xiao Guangrong, 2016/11/07
- [Qemu-devel] [PATCH 11/14] nvdimm acpi: fix two comments, Xiao Guangrong, 2016/11/07