[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] BdrvDirtyBitmap and bdrv_snapshot_goto
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] BdrvDirtyBitmap and bdrv_snapshot_goto |
|
Date: |
Tue, 8 Nov 2016 12:05:50 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 07.11.2016 um 17:10 hat Max Reitz geschrieben:
> On 07.11.2016 16:24, Vladimir Sementsov-Ogievskiy wrote:
> > Hi all!
> >
> > As I can see, in bdrv_snapshot_goto, existing dirty bitmaps are not
> > handled.. Is it ok? Should not they be filled with ones or something
> > like this?
>
> Filling them with ones makes sense to me. I guess nobody noticed because
> nobody was crazy enough to use block jobs alongside loadvm...
What's the use case in which ones make sense?
It rather seems to me that an active dirty bitmap and snapshot switching
should exclude each other because the bitmap becomes meaningless by the
switch. And chances are that after switching a snapshot you don't want
to "incrementally" backup everything, but that you should access a
different backup.
Kevin
pgpXEay99vqqL.pgp
Description: PGP signature