[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/6] blockjob: fix dead pointer in txn list
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/6] blockjob: fix dead pointer in txn list |
Date: |
Mon, 7 Nov 2016 21:47:44 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Nov 02, 2016 at 01:50:51PM -0400, John Snow wrote:
> From: Vladimir Sementsov-Ogievskiy <address@hidden>
>
> Though it is not intended to be reached through normal circumstances,
> if we do not gracefully deconstruct the transaction QLIST, we may wind
> up with stale pointers in the list.
>
> The rest of this series attempts to address the underlying issues,
> but this should fix list inconsistencies.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Tested-by: John Snow <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> [Rewrote commit message. --js]
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
>
> Signed-off-by: John Snow <address@hidden>
> ---
> blockjob.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/blockjob.c b/blockjob.c
> index 4aa14a4..4d0ef53 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -256,6 +256,7 @@ static void block_job_completed_single(BlockJob *job)
> }
>
> if (job->txn) {
> + QLIST_REMOVE(job, txn_list);
> block_job_txn_unref(job->txn);
> }
> block_job_unref(job);
> --
> 2.7.4
>
Reviewed-by: Jeff Cody <address@hidden>
[Qemu-devel] [PATCH v3 6/6] iotests: add transactional failure race test, John Snow, 2016/11/02
[Qemu-devel] [PATCH v3 5/6] blockjob: refactor backup_start as backup_job_create, John Snow, 2016/11/02