On 11/06/2016 08:55 PM, Guenter Roeck wrote:
On Tue, Oct 18, 2016 at 11:50:25PM +0200, Marek Vasut wrote:
Add nios2 disassembler support. This patch is composed from binutils files
from commit "Opcodes and assembler support for Nios II R2". The files from
binutils used in this patch are:
include/opcode/nios2.h
include/opcode/nios2r1.h
include/opcode/nios2r2.h
opcodes/nios2-opc.c
opcodes/nios2-dis.c
Signed-off-by: Marek Vasut <address@hidden>
Cc: Chris Wulff <address@hidden>
Cc: Jeff Da Silva <address@hidden>
Cc: Ley Foon Tan <address@hidden>
Cc: Sandra Loosemore <address@hidden>
Cc: Yves Vandervennet <address@hidden>
---
V3: No change
V2: Replace the nios2.c with GPL2 licensed version
checkpatch.pl reports:
total: 1967 errors, 150 warnings, 3559 lines checked
on this file. When applying it, git reports a number of whitespace problems.
Is that expected ?
Guenter
I don't know what checkpatch.pl is, or what "errors" it might be complaining
about, but I'd strongly discourage doing anything to this code that would cause it to
diverge from the binutils code it was derived from, even trivial whitespace changes.
That would only complicate propagating updates to the code to both components. (I can't
say I have any such patches in my queue right now, but I also can't rule out such changes
in the future....)
-Sandra the nios2 binutils maintainer