[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/3] utils: Add helper to read arm MIDR_EL1 r
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 2/3] utils: Add helper to read arm MIDR_EL1 register |
|
Date: |
Fri, 4 Nov 2016 14:58:15 +0000 |
On 4 November 2016 at 14:54, Vijay Kilari <address@hidden> wrote:
> What do you suggest for this?.
Some general principles:
* be consistent
* don't check things you don't need to
* prefer functions that exist in all configs (which may be
dummy functions in some cases) rather than guarding
callsites and #include lines with #ifdefs
thanks
-- PMM