[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas |
Date: |
Fri, 4 Nov 2016 01:02:24 +0100 |
User-agent: |
NeoMutt/20161014 (1.7.1) |
On 2016-11-03 15:07, Laurent Vivier wrote:
> Implement real atomic tas:
>
> When (Rn) = 0, 1 -> T
> Otherwise, 0 -> T
> In both cases, 1 -> MSB of (Rn)
>
> using atomic_fetch_or_i32() and setcondi_i32().
>
> Tested with image from:
> http://wiki.qemu.org/download/sh-test-0.2.tar.bz2
>
> This image contains a "tas_test" that runs without
> error with this change.
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> v2:
> - don't use helper but atomic_fetch_or_i32
> Thank you Paolo!
Thanks, this look good. I have tried it with my test image, and it
doesn't break it.
Reviewed-by: Aurelien Jarno <address@hidden>
Acked-by: Aurelien Jarno <address@hidden>
I consider this as a bugfix, not a new feature, so that should be fine
despite the soft freeze. Do you want me to send a pull request?
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas, (continued)
- Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas, Laurent Vivier, 2016/11/03
- Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas, John Paul Adrian Glaubitz, 2016/11/04
- Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas, John Paul Adrian Glaubitz, 2016/11/04
- Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas, Laurent Vivier, 2016/11/04
- Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas, John Paul Adrian Glaubitz, 2016/11/04
- Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas, Paolo Bonzini, 2016/11/04
- Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas, John Paul Adrian Glaubitz, 2016/11/04
- Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas, Paolo Bonzini, 2016/11/04
Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas,
Aurelien Jarno <=