Re: [Qemu-devel] [PATCH v3 4/4] pc: memhp: enable nvdimm device hotplug

[Xiao Guangrong]

On 11/02/2016 07:21 PM, Igor Mammedov wrote:
> On Sat, 29 Oct 2016 00:35:40 +0800
> Xiao Guangrong <address@hidden> wrote:
>
> > _GPE.E04 is dedicated for nvdimm device hotplug
> >
> > Signed-off-by: Xiao Guangrong <address@hidden>
> > ---
> >  docs/specs/acpi_mem_hotplug.txt      |  3 +++
> >  hw/acpi/memory_hotplug.c             | 31 +++++++++++++++++++++++--------
> >  hw/i386/acpi-build.c                 |  7 +++++++
> >  hw/i386/pc.c                         | 12 ++++++++++++
> >  hw/mem/nvdimm.c                      |  4 ----
> >  include/hw/acpi/acpi_dev_interface.h |  1 +
> >  6 files changed, 46 insertions(+), 12 deletions(-)
> >
> > diff --git a/docs/specs/acpi_mem_hotplug.txt b/docs/specs/acpi_mem_hotplug.txt
> > index 3df3620..cb26dd2 100644
> > --- a/docs/specs/acpi_mem_hotplug.txt
> > +++ b/docs/specs/acpi_mem_hotplug.txt
> > @@ -4,6 +4,9 @@ QEMU<->ACPI BIOS memory hotplug interface
> >  ACPI BIOS GPE.3 handler is dedicated for notifying OS about memory hot-add
> >  and hot-remove events.
> >
> > +ACPI BIOS GPE.4 handler is dedicated for notifying OS about nvdimm device
> > +hot-add and hot-remove events.
> that should be part of nvdimm spec

Okay.

> >  Memory hot-plug interface (IO port 0xa00-0xa17, 1-4 byte access):
> >  ---------------------------------------------------------------
> >  0xa00:
> > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
> > index ec4e64b..70f6451 100644
> > --- a/hw/acpi/memory_hotplug.c
> > +++ b/hw/acpi/memory_hotplug.c
> so far nvdimm hotplug has nothing do with memory hotplug so revert
> all changes you did to this file and put nvdimm hotplug handler
> code into hw/acpi/nvdimm.c
>
> and call it from respective ich9/piix4_pm handlers.

Okay.