[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] build failures in master
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] build failures in master |
Date: |
Wed, 2 Nov 2016 09:26:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 02.11.2016 09:14, Thomas Huth wrote:
> On 02.11.2016 08:03, Olaf Hering wrote:
>> Not sure if there are automated build tests to catch such mistakes,
>> these errors appeared after qemu-20161028T142950.fd209e4:
>>
>> [ 337s] ../hw/xen/xen_pvdev.o: In function `xen_pv_printf':
>> [ 337s]
>> /home/abuild/rpmbuild/BUILD/qemu-20161101T165305.4eb28ab/hw/xen/xen_pvdev.c:220:
>> undefined reference to `qemu_log_vprintf'
>
> Does it work if you add an explicit #include "qemu/log.h" at the
> beginning of that file (after osdep.h)?
>
>> [ 220s] ui/gtk.c: In function 'gd_text_key_down':
>> [ 220s] ui/gtk.c:1073: error: 'GDK_KEY_Delete' undeclared (first use in
>> this function)
>
> That one is strange ... it should get defined by <gdk/gdkkeysyms.h>
> which we include from include/ui/gtk.h (and that file is included in
> ui/gtk.c), so I fail to see how that could not be defined on your
> system. Which version of GTK are you using?
OK, looks like the name changed with gtk version 2.22:
https://git.gnome.org/browse/gtk+/commit/gdk/gdkkeysyms.h?id=913cdf3be750a1e74c09b20edf55a57f9a919fcc
I'll try to come up with a patch for this issue (since we still seem to
support gtk 2.18 in QEMU) ...
Thomas
signature.asc
Description: OpenPGP digital signature