Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

[Daniel P. Berrange]

On Mon, Oct 31, 2016 at 11:34:58PM -0700, Ashish Mittal wrote:
> Source code for the qnio library that this code loads can be downloaded
> from:
> https://github.com/MittalAshish/libqnio.git

Your patch is unable to compile against this, because the qnio_api.h
header is using a "struct iovec" type in its APIs, but not including
any header to define that type. This causes configure to fail

cc -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 
-I/usr/lib64/glib-2.0/include -D_GNU_SOURCE -fPIE -DPIE -m64 -mcx16 
-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes 
-Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes 
-fno-strict-aliasing -fno-common -fwrapv 
-I/home/berrange/src/external/libqnio/src -Wendif-labels 
-Wno-shift-negative-value -Wmissing-include-dirs -Wempty-body -Wnested-externs 
-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers 
-Wold-style-declaration -Wold-style-definition -Wtype-limits 
-fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpng16 
-I/usr/include/cacard -I/usr/include/nss3 -I/usr/include/nspr4 
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libusb-1.0 
-o config-temp/qemu-conf.exe config-temp/qemu-conf.c -Wl,-z,relro -Wl,-z,now 
-pie -m64 -g -L/home/berrange/src/external/libqnio/src -lqnio
In file included from config-temp/qemu-conf.c:2:0:
/home/berrange/src/external/libqnio/src/qnio/qnio_api.h:186:54: error: ‘struct 
iovec’ declared inside parameter list will not be visible outside of this 
definition or declaration [-Werror]
 int32_t iio_writev(void *apictx, int32_t rfd, struct iovec *iov, int iovcnt,
                                                      ^~~~~
/home/berrange/src/external/libqnio/src/qnio/qnio_api.h:189:53: error: ‘struct 
iovec’ declared inside parameter list will not be visible outside of this 
definition or declaration [-Werror]
 int32_t iio_readv(void *apictx, int32_t rfd, struct iovec *iov, int iovcnt,
                                                     ^~~~~
cc1: all warnings being treated as errors



Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|