Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

[Michael S. Tsirkin]

On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov wrote:
> On Sun, 30 Oct 2016 23:23:18 +0200
> "Michael S. Tsirkin" <address@hidden> wrote:
> 
> > The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6:
> > 
> >   Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' 
> > into staging (2016-10-28 17:59:04 +0100)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > 
> > for you to fetch changes up to f082ec0225bd15c71e0b4697d2df3af7bad65d7f:
> > 
> >   acpi: fix assert failure caused by commit 35c5a52d (2016-10-30 20:06:25 
> > +0200)
> > 
> > ----------------------------------------------------------------
> > virtio, pc: fixes and features
> > 
> > nvdimm hotplug support
> Michael,
> 
> Could you drop nvdimm hotplug from pull request (I should review at least 
> once as it touches not only NVDIMMs but a generic hotplug infrastructure)
> 
> and keep only nvdimm fixes/cleanups for now?

If I drop it now it won't be in the next QEMU and it seems like
a valuable feature. The comments so far are about minor style
improvements that IMO can be addressed by patches on top.

We can always revert if you see bigger issues, but let's enable the
testing of this feature.


> 
> > virtio migration and ioeventfd rework
> > virtio crypto device
> > ipmi fixes
> > 
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > 
> > ----------------------------------------------------------------
> > Corey Minyard (5):
> >       ipmi: Remove hotplug from IPMI BMCs
> >       ipmi_bmc_sim: Remove an unnecessary mutex
> >       ipmi: Implement shutdown via ACPI overtemp
> >       ipmi: Add graceful shutdown handling to the external BMC
> >       acpi/ipmi: Initialize the fwinfo before fetching it
> > 
> > Cédric Le Goater (1):
> >       ipmi: chassis poweroff should use qemu_system_shutdown_request()
> > 
> > Daniel P. Berrange (1):
> >       ipmi: fix build config variable name for ipmi_bmc_extern.o
> > 
> > Dr. David Alan Gilbert (2):
> >       virtio/migration: Add VMStateDescription to VirtioDeviceClass
> >       virtio/migration: Migrate balloon to VMState
> > 
> > Gonglei (12):
> >       cryptodev: introduce cryptodev backend interface
> >       cryptodev: add symmetric algorithm operation stuff
> >       virtio-crypto: introduce virtio_crypto.h
> >       cryptodev: introduce a new cryptodev backend
> >       virtio-crypto: add virtio crypto device emulation
> >       virtio-crypto-pci: add virtio crypto pci support
> >       virtio-crypto: set capacity of algorithms supported
> >       virtio-crypto: add control queue handler
> >       virtio-crypto: add data queue processing handler
> >       cryptodev: introduce an unified wrapper for crypto operation
> >       virtio-crypto: using bh to handle dataq's requests
> >       virtio-crypto: add myself as virtio-crypto and cryptodev backends 
> > maintainer
> > 
> > Haozhong Zhang (1):
> >       acpi: fix assert failure caused by commit 35c5a52d
> > 
> > Paolo Bonzini (13):
> >       virtio: disable ioeventfd as early as possible
> >       virtio: move ioeventfd_disabled flag to VirtioBusState
> >       virtio: move ioeventfd_started flag to VirtioBusState
> >       virtio: add start_ioeventfd and stop_ioeventfd to VirtioDeviceClass
> >       virtio: introduce virtio_device_ioeventfd_enabled
> >       virtio-blk: always use dataplane path if ioeventfd is active
> >       virtio-scsi: always use dataplane path if ioeventfd is active
> >       Revert "virtio: Introduce virtio_add_queue_aio"
> >       virtio: remove set_handler argument from set_host_notifier_internal
> >       virtio: remove ioeventfd_disabled altogether
> >       virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd
> >       virtio: inline virtio_queue_set_host_notifier_fd_handler
> >       virtio: inline set_host_notifier_internal
> > 
> > Xiao Guangrong (12):
> >       acpi nvdimm: fix wrong buffer size returned by DSM method
> >       acpi nvdimm: fix OperationRegion definition
> >       acpi nvdimm: fix device physical address base
> >       acpi nvdimm: fix ARG3 conflict
> >       acpi nvdimm: fix Arg6 usage
> >       nvdimm acpi: compile nvdimm acpi code arch-independently
> >       acpi nvdimm: rename result_size to dsm_out_buf_siz
> >       nvdimm acpi: use common macros instead of magic names
> >       nvdimm acpi: prebuild nvdimm devices for available slots
> >       nvdimm acpi: introduce fit buffer
> >       nvdimm acpi: introduce _FIT
> >       pc: memhp: enable nvdimm device hotplug
> > 
> >  hw/block/dataplane/virtio-blk.h                |   6 +-
> >  hw/s390x/virtio-ccw.h                          |   2 -
> >  hw/virtio/virtio-pci.h                         |  17 +-
> >  include/hw/acpi/acpi_dev_interface.h           |   1 +
> >  include/hw/hotplug.h                           |  10 +
> >  include/hw/mem/nvdimm.h                        |  27 +-
> >  include/hw/virtio/virtio-bus.h                 |  27 +-
> >  include/hw/virtio/virtio-crypto.h              | 101 +++
> >  include/hw/virtio/virtio-scsi.h                |   6 +-
> >  include/hw/virtio/virtio.h                     |  15 +-
> >  include/standard-headers/linux/virtio_crypto.h | 429 ++++++++++++
> >  include/standard-headers/linux/virtio_ids.h    |   2 +-
> >  include/sysemu/cryptodev.h                     | 298 ++++++++
> >  backends/cryptodev-builtin.c                   | 361 ++++++++++
> >  backends/cryptodev.c                           | 245 +++++++
> >  hw/acpi/ipmi.c                                 |   1 +
> >  hw/acpi/memory_hotplug.c                       |  31 +-
> >  hw/acpi/nvdimm.c                               | 468 ++++++++++---
> >  hw/block/dataplane/virtio-blk.c                |  73 +-
> >  hw/block/virtio-blk.c                          |  15 +-
> >  hw/core/hotplug.c                              |  11 +
> >  hw/core/qdev.c                                 |  20 +-
> >  hw/i386/acpi-build.c                           |   9 +-
> >  hw/i386/pc.c                                   |  31 +
> >  hw/ipmi/ipmi.c                                 |  10 +-
> >  hw/ipmi/ipmi_bmc_extern.c                      |  12 +-
> >  hw/ipmi/ipmi_bmc_sim.c                         |   7 +-
> >  hw/mem/nvdimm.c                                |   4 -
> >  hw/s390x/virtio-ccw.c                          |  44 +-
> >  hw/scsi/virtio-scsi-dataplane.c                |  56 +-
> >  hw/scsi/virtio-scsi.c                          |  24 +-
> >  hw/virtio/vhost.c                              |   5 +-
> >  hw/virtio/virtio-balloon.c                     |  31 +-
> >  hw/virtio/virtio-bus.c                         | 154 ++---
> >  hw/virtio/virtio-crypto-pci.c                  |  77 +++
> >  hw/virtio/virtio-crypto.c                      | 898 
> > +++++++++++++++++++++++++
> >  hw/virtio/virtio-mmio.c                        |  35 +-
> >  hw/virtio/virtio-pci.c                         |  40 +-
> >  hw/virtio/virtio.c                             | 153 +++--
> >  tests/ipmi-bt-test.c                           |   2 +-
> >  MAINTAINERS                                    |  13 +
> >  backends/Makefile.objs                         |   3 +
> >  docs/specs/acpi_mem_hotplug.txt                |   3 +
> >  docs/specs/acpi_nvdimm.txt                     |  58 +-
> >  hw/acpi/Makefile.objs                          |   2 +-
> >  hw/ipmi/Makefile.objs                          |   2 +-
> >  hw/virtio/Makefile.objs                        |   2 +
> >  qemu-options.hx                                |  18 +
> >  48 files changed, 3352 insertions(+), 507 deletions(-)
> >  create mode 100644 include/hw/virtio/virtio-crypto.h
> >  create mode 100644 include/standard-headers/linux/virtio_crypto.h
> >  create mode 100644 include/sysemu/cryptodev.h
> >  create mode 100644 backends/cryptodev-builtin.c
> >  create mode 100644 backends/cryptodev.c
> >  create mode 100644 hw/virtio/virtio-crypto-pci.c
> >  create mode 100644 hw/virtio/virtio-crypto.c
> > 
> >