Re: [Qemu-devel] [PULL 03/18] migration: Enter into COLO mode after migration if COLO is enabled

[Eric Blake]

On 10/30/2016 05:46 AM, Amit Shah wrote:
> From: zhanghailiang <address@hidden>
> 
> Add a new migration state: MIGRATION_STATUS_COLO. Migration source side
> enters this state after the first live migration successfully finished
> if COLO is enabled by command 'migrate_set_capability x-colo on'.
> 
> We reuse migration thread, so the process of checkpointing will be handled
> in migration thread.
> 

> +++ b/qapi-schema.json
> @@ -459,12 +459,14 @@
>  #
>  # @failed: some error occurred during migration process.
>  #
> +# @colo: VM is in the process of fault tolerance. (since 2.8)
> +#

The commit message mentions it, but the public documentation does not,
so it might be worth a followup patch that clarifies in the schema that
the 'colo' state is not possible without using the 'x-colo' migration
property (so that applications like libvirt know that they don't have to
worry about handling an unexpected state, at least not in 2.8 or until
the 'x-colo' is promoted to plain 'colo').

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature