[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only co
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands |
Date: |
Mon, 31 Oct 2016 23:38:24 +0800 |
Checking the status of an image when it is being used by guest is
usually useful, and there is no risk of corrupting data, so don't let
the upcoming image locking feature limit this use case.
Signed-off-by: Fam Zheng <address@hidden>
---
qemu-img.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index afcd51f..b2f4077 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -679,6 +679,10 @@ static int img_check(int argc, char **argv)
break;
}
}
+
+ if (!(flags & BDRV_O_RDWR)) {
+ flags |= BDRV_O_SHARE_RW;
+ }
if (optind != argc - 1) {
error_exit("Expecting one image file name");
}
@@ -1231,6 +1235,7 @@ static int img_compare(int argc, char **argv)
goto out3;
}
+ flags |= BDRV_O_SHARE_RW;
blk1 = img_open(image_opts, filename1, fmt1, flags, writethrough, quiet);
if (!blk1) {
ret = 2;
@@ -2279,7 +2284,8 @@ static ImageInfoList *collect_image_info_list(bool
image_opts,
g_hash_table_insert(filenames, (gpointer)filename, NULL);
blk = img_open(image_opts, filename, fmt,
- BDRV_O_NO_BACKING | BDRV_O_NO_IO, false, false);
+ BDRV_O_NO_BACKING | BDRV_O_NO_IO | BDRV_O_SHARE_RW,
+ false, false);
if (!blk) {
goto err;
}
@@ -2605,7 +2611,7 @@ static int img_map(int argc, char **argv)
return 1;
}
- blk = img_open(image_opts, filename, fmt, 0, false, false);
+ blk = img_open(image_opts, filename, fmt, BDRV_O_SHARE_RW, false, false);
if (!blk) {
return 1;
}
--
2.7.4
- [Qemu-devel] [PATCH 00/14] block: Image locking series, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 01/14] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 02/14] block: Define BDRV_O_SHARE_RW, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 03/14] qemu-io: Set "share-rw" flag together with read-only, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands,
Fam Zheng <=
- [Qemu-devel] [PATCH 05/14] block: Set "share-rw" flag in drive-backup when sync=none, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 06/14] block: Set "share-rw" flag for incoming migration, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 07/14] iotests: 055: Don't attach the drive to vm for drive-backup, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 08/14] iotests: 030: Read-only open image for getting map, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 09/14] iotests: 087: Don't attch test image twice, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 10/14] iotests: 085: Avoid image locking conflict, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 11/14] iotests: 091: Quit QEMU before checking image, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 12/14] tests: Use null-co:// instead of /dev/null as the dummy image, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 14/14] tests: Add test-image-lock, Fam Zheng, 2016/10/31
- [Qemu-devel] [PATCH 13/14] raw-posix: Implement image locking, Fam Zheng, 2016/10/31