qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 01/27] checkpatch: tweak "struct should normally be c


From: Paolo Bonzini
Subject: [Qemu-devel] [PULL 01/27] checkpatch: tweak "struct should normally be const" warning
Date: Mon, 31 Oct 2016 15:37:17 +0100

Avoid triggering on

    typedef struct BlockJobDriver BlockJobDriver;

or

    struct BlockJobDriver {

Cc: John Snow <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 scripts/checkpatch.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3afa19a..1f1c9d3 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2498,8 +2498,8 @@ sub process {
                                VMStateDescription|
                                VMStateInfo}x;
                if ($line !~ /\bconst\b/ &&
-                   $line =~ /\b($struct_ops)\b/) {
-                       ERROR("struct $1 should normally be const\n" .
+                   $line =~ /\b($struct_ops)\b.*=/) {
+                       ERROR("initializer for struct $1 should normally be 
const\n" .
                                $herecurr);
                }
 
-- 
2.7.4





reply via email to

[Prev in Thread] Current Thread [Next in Thread]