[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] qapi: allow blockdev-add for NFS
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] qapi: allow blockdev-add for NFS |
Date: |
Thu, 27 Oct 2016 18:45:21 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.10.2016 um 12:43 hat Ashijeet Acharya geschrieben:
> Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to
> support blockdev-add for NFS network protocol driver. Also make a new
> struct NFSServer to support tcp connection.
>
> Signed-off-by: Ashijeet Acharya <address@hidden>
> ---
> qapi/block-core.json | 77
> +++++++++++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 73 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 9d797b8..75e28aa 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1708,15 +1708,16 @@
> #
> # @host_device, @host_cdrom: Since 2.1
> # @gluster: Since 2.7
> +# @nfs: Since 2.8
> #
> # Since: 2.0
> ##
> { 'enum': 'BlockdevDriver',
> 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
> 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
> - 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-co',
> - 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
> - 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
> + 'host_device', 'http', 'https', 'luks', 'nfs', 'null-aio',
> + 'null-co', 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
> + 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
>
> ##
> # @BlockdevOptionsFile
> @@ -2212,6 +2213,74 @@
> '*top-id': 'str' } }
>
> ##
> +# @NFSTransport
> +#
> +# An enumeration of NFS transport types
> +#
> +# @inet: host address for NFS server
This description belongs to the 'host' field in NFSServer. Here it
should probably say something like "TCP transport".
> +# Since 2.8
> +##
> +{ 'enum': 'NFSTransport',
> + 'data': [ 'inet' ] }
> +
> +##
> +# @NFSServer
> +#
> +# Captures the address of the socket
> +#
> +# @type: transport type used for NFS (only TCP supported)
> +#
> +# @inet: host address for NFS server
Here the description is right, but the field name is wrong (should be
@host instead of @inet).
> +# Since 2.8
> +##
> +{ 'struct': 'NFSServer',
> + 'data': { 'type': 'NFSTransport',
> + 'host': 'str' } }
> +
Kevin