Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

[Hailiang Zhang]

On 2016/10/26 21:42, Eric Blake wrote:
> On 10/26/2016 01:07 AM, Amit Shah wrote:
> > On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote:
> > > configure --enable-colo/--disable-colo to switch COLO
> > > support on/off.
> > > COLO feature is enabled by default.
> > >
> > > Signed-off-by: zhanghailiang <address@hidden>
> > > Signed-off-by: Li Zhijian <address@hidden>
> > > Signed-off-by: Gonglei <address@hidden>
> > > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> >
> > Reviewed-by: Amit Shah <address@hidden>
> >
> > > v19:
> > > - fix colo_supported() to return true
> > > v11:
> > > - Turn COLO on in default (Eric's suggestion)
> >
> > Can you recap why the suggestion was made to switch it on by default?
>
> If the feature doesn't depend on external libraries, then enabling
> compilation by default will avoid bitrot.

I agreed.

> But mentioning this rationale in the commit message never hurts :)

Good idea, i'll add this instruction in commit message.
Thank you very much for your speedy reply. :)