[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] trace: Fix 'char **' compilation error in si
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] trace: Fix 'char **' compilation error in simple backend |
|
Date: |
Wed, 26 Oct 2016 08:18:35 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/25/2016 10:50 PM, Fam Zheng wrote:
> Currently, the generated function body will do "strlen(arg)" but the
> argument could be 'char **' or 'char * const *'. Avoid that by excluding
> such cases in is_string check.
>
> Reported by patchew's "make address@hidden".
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
>
> ---
>
> v2: Fix typo in commit message and "yeah we'll be counting stars". [Eric]
I may have had the vague idea, but you eloquently framed it into code,
and let me learn in the process :)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature