[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/3] target-ppc: add vrldnmi and vrlwmi instr
|
From: |
Nikunj A Dadhania |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 2/3] target-ppc: add vrldnmi and vrlwmi instructions |
|
Date: |
Wed, 26 Oct 2016 10:13:02 +0530 |
|
User-agent: |
Notmuch/0.21 (https://notmuchmail.org) Emacs/25.0.94.1 (x86_64-redhat-linux-gnu) |
Richard Henderson <address@hidden> writes:
> On 10/24/2016 11:19 PM, Nikunj A Dadhania wrote:
>> + begin = extract##size(src2, size - begin_last - 1, num_bits); \
>> + end = extract##size(src2, size - end_last - 1, num_bits); \
>> + shift = extract##size(src2, size - shift_last - 1, num_bits); \
>
> What I mean is
>
> shift = extract##size(src2, 0, 6);
> end = extract##size(src2, 8, 6);
> begin = extract##size(src2, 16, 6);
>
> The values are at the *same* position for both instructions. There's no need
> to parameterize with silly bigendian numberings.
Ah.. ok. You are right.
Regards
Nikunj