qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] i.MX: Fix GPIO ISR register write


From: Jean-Christophe DUBOIS
Subject: Re: [Qemu-devel] [PATCH] i.MX: Fix GPIO ISR register write
Date: Tue, 25 Oct 2016 11:47:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

Le 25/10/2016 à 04:03, Guenter Roeck a écrit :
Writing the ISR register is supposed to clear interrupt status bits,
not to set them.

This patch makes '-M sabrelite' work without devicetree changes (Linux
kernel versions 3.18 to 4.7 with imx_v6_v7_defconfig and up to v4.8 with
multi_v7_defconfig; mainline has different problems).

Signed-off-by: Guenter Roeck <address@hidden>
---
  hw/gpio/imx_gpio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c
index f3574aa..c36c394 100644
--- a/hw/gpio/imx_gpio.c
+++ b/hw/gpio/imx_gpio.c
@@ -237,7 +237,7 @@ static void imx_gpio_write(void *opaque, hwaddr offset, 
uint64_t value,
          break;
case ISR_ADDR:
-        s->isr |= ~value;
+        s->isr &= ~value;
          imx_gpio_set_all_int_lines(s);
          break;

acked-by: Jean-Christophe Dubois <address@hidden>

Thanks.

JC



reply via email to

[Prev in Thread] Current Thread [Next in Thread]