Re: [Qemu-devel] [PULL 00/17] x86 and CPU queue, 2016-10-24

[Eduardo Habkost]

On Mon, Oct 24, 2016 at 06:26:44PM +0100, Peter Maydell wrote:
> On 24 October 2016 at 17:34, Eduardo Habkost <address@hidden> wrote:
> > On Mon, Oct 24, 2016 at 05:20:17PM +0100, Peter Maydell wrote:
> >> Tests should never print out strings with "warning:" in them,
> >> to avoid false-positives when scanning build logs.
> >>
> >> I'm not entirely sure why these only happen on OSX, though.
> >
> > Probably the host has an older glib version that doesn't support
> > subprocesses. In this case, the
> > "/x86/cpuid/parsing-plus-minus/subprocess" test case will be run
> > on the main process.
> >
> > I thought that would be better than skipping the test case
> > entirely. But I can #ifdef the entire
> > "/x86/cpuid/parsing-plus-minus/subprocess" test case if that's
> > better.
> 
> I don't particularly mind how you resolve it; but "don't print
> warning: or error: unless there's a failure" is a line I'd like
> to hold to.

OK, I will fix it in v2.

-- 
Eduardo