[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 10/37] cputlb: Replace SHIFT with DATA_SIZE
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v8 10/37] cputlb: Replace SHIFT with DATA_SIZE |
Date: |
Mon, 24 Oct 2016 10:39:21 -0700 |
Reviewed-by: Emilio G. Cota <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
cputlb.c | 16 ++++++++--------
softmmu_template.h | 7 ++-----
2 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/cputlb.c b/cputlb.c
index 3c99c34..5575b73 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -529,16 +529,16 @@ static bool victim_tlb_hit(CPUArchState *env, size_t
mmu_idx, size_t index,
#define MMUSUFFIX _mmu
-#define SHIFT 0
+#define DATA_SIZE 1
#include "softmmu_template.h"
-#define SHIFT 1
+#define DATA_SIZE 2
#include "softmmu_template.h"
-#define SHIFT 2
+#define DATA_SIZE 4
#include "softmmu_template.h"
-#define SHIFT 3
+#define DATA_SIZE 8
#include "softmmu_template.h"
#undef MMUSUFFIX
@@ -547,14 +547,14 @@ static bool victim_tlb_hit(CPUArchState *env, size_t
mmu_idx, size_t index,
#define GETPC() ((uintptr_t)0)
#define SOFTMMU_CODE_ACCESS
-#define SHIFT 0
+#define DATA_SIZE 1
#include "softmmu_template.h"
-#define SHIFT 1
+#define DATA_SIZE 2
#include "softmmu_template.h"
-#define SHIFT 2
+#define DATA_SIZE 4
#include "softmmu_template.h"
-#define SHIFT 3
+#define DATA_SIZE 8
#include "softmmu_template.h"
diff --git a/softmmu_template.h b/softmmu_template.h
index 27ed269..f9c51fe 100644
--- a/softmmu_template.h
+++ b/softmmu_template.h
@@ -25,8 +25,6 @@
#include "exec/address-spaces.h"
#include "exec/memory.h"
-#define DATA_SIZE (1 << SHIFT)
-
#if DATA_SIZE == 8
#define SUFFIX q
#define LSUFFIX q
@@ -134,7 +132,7 @@ static inline DATA_TYPE glue(io_read, SUFFIX)(CPUArchState
*env,
}
cpu->mem_io_vaddr = addr;
- memory_region_dispatch_read(mr, physaddr, &val, 1 << SHIFT,
+ memory_region_dispatch_read(mr, physaddr, &val, DATA_SIZE,
iotlbentry->attrs);
return val;
}
@@ -311,7 +309,7 @@ static inline void glue(io_write, SUFFIX)(CPUArchState *env,
cpu->mem_io_vaddr = addr;
cpu->mem_io_pc = retaddr;
- memory_region_dispatch_write(mr, physaddr, val, 1 << SHIFT,
+ memory_region_dispatch_write(mr, physaddr, val, DATA_SIZE,
iotlbentry->attrs);
}
@@ -492,7 +490,6 @@ void probe_write(CPUArchState *env, target_ulong addr, int
mmu_idx,
#endif /* !defined(SOFTMMU_CODE_ACCESS) */
#undef READ_ACCESS_TYPE
-#undef SHIFT
#undef DATA_TYPE
#undef SUFFIX
#undef LSUFFIX
--
2.7.4
- [Qemu-devel] [PATCH v8 00/37] cmpxchg atomic operations, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 02/37] atomics: add atomic_xor, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 03/37] atomics: add atomic_op_fetch variants, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 01/37] atomics: Add parameters to macros, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 05/37] exec: Avoid direct references to Int128 parts, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 07/37] int128: Add int128_make128, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 04/37] atomics: Add __nocheck atomic operations, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 06/37] int128: Use __int128 if available, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 09/37] linux-user: enable parallel code generation on clone, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 11/37] cputlb: Move probe_write out of softmmu_template.h, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 10/37] cputlb: Replace SHIFT with DATA_SIZE,
Richard Henderson <=
- [Qemu-devel] [PATCH v8 14/37] cputlb: Tidy some macros, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 19/37] target-i386: emulate LOCK'ed cmpxchg using cmpxchg helpers, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 18/37] tcg: Emit barriers with parallel_cpus, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 13/37] cputlb: Move most of iotlb code out of line, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 16/37] tcg: Add atomic128 helpers, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 20/37] target-i386: emulate LOCK'ed OP instructions using atomic helpers, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 12/37] cputlb: Remove includes from softmmu_template.h, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 17/37] tcg: Add CONFIG_ATOMIC64, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 15/37] tcg: Add atomic helpers, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 24/37] target-i386: emulate LOCK'ed XADD using atomic helper, Richard Henderson, 2016/10/24