Re: [Qemu-devel] [PATCH v4 0/2] Script changes to find duplicate #include entries

[Anand J]

ping

On Fri, Oct 21, 2016 at 12:27 PM, Anand J <address@hidden> wrote:

> There were some files in the code base with multiple inclusion of the same
> header files.
> Following changes are made to mitigate this issue.
>
>  1) --check-dup-head option is added to the scripts/clean-includes to
> search files and
>     find out such entries. This will help to catch redundant #includes in
> the future.
>  2) Removed most of the duplicate entries currently present in the code
> base using the
>     script.
>
> Anand J (2):
>   scripts/clean-includes: added duplicate #include check
>   clean-up: removed duplicate #includes
>
>  accel.c                             |  1 -
>  cputlb.c                            |  1 -
>  gdbstub.c                           |  1 -
>  hw/i386/acpi-build.c                |  1 -
>  hw/microblaze/boot.c                |  1 -
>  hw/mips/mips_malta.c                |  1 -
>  hw/nvram/fw_cfg.c                   |  1 -
>  hw/pci-bridge/pci_expander_bridge.c |  1 -
>  hw/ppc/ppc405_boards.c              |  1 -
>  hw/ppc/spapr.c                      |  1 -
>  hw/timer/grlib_gptimer.c            |  1 -
>  hw/tpm/tpm_tis.c                    |  1 -
>  hw/unicore32/puv3.c                 |  1 -
>  hw/usb/dev-mtp.c                    |  1 -
>  include/hw/i386/pc.h                |  1 -
>  monitor.c                           |  2 --
>  qemu-io-cmds.c                      |  1 -
>  qmp.c                               |  1 -
>  scripts/clean-includes              | 56 +++++++++++++++++++++++++++---
> -------
>  target-i386/machine.c               |  3 --
>  target-mips/machine.c               |  1 -
>  target-ppc/machine.c                |  1 -
>  target-ppc/mem_helper.c             |  1 -
>  target-sparc/machine.c              |  3 --
>  target-xtensa/translate.c           |  1 -
>  tests/crypto-tls-x509-helpers.h     |  3 --
>  tests/vhost-user-test.c             |  2 --
>  util/oslib-posix.c                  |  1 -
>  vl.c                                |  1 -
>  29 files changed, 42 insertions(+), 50 deletions(-)
>
> --
> 2.7.4
>
>