[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] ssh: switch from libssh2 to libssh
From: |
Pino Toscano |
Subject: |
Re: [Qemu-devel] [PATCH v2] ssh: switch from libssh2 to libssh |
Date: |
Fri, 21 Oct 2016 17:30:39 +0200 |
User-agent: |
KMail/5.3.1 (Linux/4.7.3-200.fc24.x86_64; KDE/5.26.0; x86_64; ; ) |
On Friday, 21 October 2016 13:02:21 CEST Richard W.M. Jones wrote:
> On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote:
> > Rewrite the implementation of the ssh block driver to use libssh instead
> > of libssh2. The libssh library has various advantages over libssh2:
> > - easier API for authentication (for example for using ssh-agent)
> > - easier API for known_hosts handling
> > - supports newer types of keys in known_hosts
> >
> > Kerberos authentication can be enabled once the libssh bug for it [1] is
> > fixed.
> >
> > The development version of libssh (i.e. the future 0.8.x) supports
> > fsync, so reuse the build time check for this.
> >
> > [1] https://red.libssh.org/issues/242
> >
> > Signed-off-by: Pino Toscano <address@hidden>
> > ---
> >
> > Changes from v1:
> > - fixed jumbo packets writing
> > - fixed missing 'err' assignment
> > - fixed commit message
>
> This version works, but I also switched from using a remote server to
> using this over localhost.
Could you please give it a try with the remote server case as well?
> It seems as if the timeout might be a bit short. Could that be made
> controllable? Or increased to match whatever libssh2 was using?
Which timeout are you referring to?
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.