Re: [Qemu-devel] [Qemu-ppc] (no subject)

[Cédric Le Goater]

On 10/20/2016 08:59 AM, Nicholas Piggin wrote:
> Date: Thu, 20 Oct 2016 17:38:24 +1100
> Subject: [PATCH 0/3] ppc: system reset interrupt fixes and new hcall IPI
> 
> Hi,
> 
> We are implementing this new unmaskable IPI hcall for crash dumping
> and debugging. I had some issues with QEMU delivering system reset
> interrupt to guests, which was caused by the HV bit being set. After
> changing that, the interrupt was being handled okay. Should there be
> a more general check to ensure the HV bit is not set in the guest?

cpu_ppc_set_papr() called by cpu_init() does : 

        env->msr_mask &= ~((1ull << MSR_EP) | MSR_HVB);

and then for the reset : 

ppc_cpu_reset() 
        hreg_store_msr()
                value &= env->msr_mask;

at first sight, we should be fine ? 

C. 

> 
> I implemented Linux support for the new hcall in crashdump code, and
> it works.
> 
> Thanks,
> Nick
> 
> Nicholas Piggin (3):
>   ppc: fix MSR_ME handling for system reset interrupt
>   ppc: allow system reset interrupt to be delivered to guests
>   ppc/spapr: implement H_SIGNAL_SYS_RESET
> 
>  hw/ppc/spapr_hcall.c     | 42 ++++++++++++++++++++++++++++++++++++++++++
>  include/hw/ppc/spapr.h   |  8 +++++++-
>  target-ppc/excp_helper.c | 10 +++++++---
>  3 files changed, 56 insertions(+), 4 deletions(-)
>