Re: [Qemu-devel] [PATCHv3 08/11] tests: Clean up IO handling in ide-test

[Laurent Vivier]

On 20/10/2016 05:43, David Gibson wrote:
> ide-test uses many explicit inb() / outb() operations for its IO, which
> means it's not portable to non-x86 platforms.  This cleans it up to use
> the libqos PCI accessors instead.
> 
> Signed-off-by: David Gibson <address@hidden>
> ---
>  tests/ide-test.c | 181 
> ++++++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 119 insertions(+), 62 deletions(-)
> 
> diff --git a/tests/ide-test.c b/tests/ide-test.c
> index a8a4081..454fcf8 100644
> --- a/tests/ide-test.c
> +++ b/tests/ide-test.c
...
> @@ -494,7 +523,7 @@ static void test_identify(void)
>      g_assert(ret == 0);
>  
>      /* Write cache enabled bit */
> -    assert_bit_set(buf[85], 0x20);
> +    assert_bit_set(le16_to_cpu(buf[85]), 0x20);
>  
>      ide_test_quit();
>  }

This assert breaks the test on BE host.

TEST: tests/ide-test... (pid=7945)
  /i386/ide/identify:                                                  **
ERROR:/home/laurent/Projects/qemu/tests/ide-test.c:525:test_identify:
assertion failed ((le16_to_cpu(buf[85])) & (0x20) == (0x20)):
(0x00000000 == 0x00000020)
FAIL

Thanks,
Laurent