qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 13/13] virtio: inline set_host_notifier_internal


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH 13/13] virtio: inline set_host_notifier_internal
Date: Wed, 19 Oct 2016 13:26:53 +0200

On Mon, 10 Oct 2016 13:53:41 +0200
Paolo Bonzini <address@hidden> wrote:

> This is only called from virtio_bus_set_host_notifier.
> 
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>         v1->v2: rebase after commit a8bba0a ("virtio: Tell the user what went
>         wrong when event_notifier_init failed", 2016-09-09)
> 
>  hw/virtio/virtio-bus.c | 62 
> +++++++++++++++++++++-----------------------------
>  1 file changed, 26 insertions(+), 36 deletions(-)
> 

> +cleanup_event_notifier:
> +    /* Test and clear notifier before after disabling event,

I always stumble over that "before after" :)

> +     * in case poll callback didn't have time to run.
> +     */
> +    virtio_queue_host_notifier_read(notifier);
> +    event_notifier_cleanup(notifier);
> +    return r;
>  }
> 
>  static char *virtio_bus_get_dev_path(DeviceState *dev)

Reviewed-by: Cornelia Huck <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]