Re: [Qemu-devel] [PATCH v1 2/3] target-ppc: implement vnegw/d instructions

[Nikunj A Dadhania]

David Gibson <address@hidden> writes:

> [ Unknown signature status ]
> On Wed, Oct 12, 2016 at 10:38:52AM +0530, Nikunj A Dadhania wrote:
>> Vector Integer Negate Instructions:
>> 
>> vnegw: Vector Negate Word
>> vnegd: Vector Negate Doubleword
>> 
>> Signed-off-by: Nikunj A Dadhania <address@hidden>
>> ---
>>  target-ppc/helper.h                 |  2 ++
>>  target-ppc/int_helper.c             | 12 ++++++++++++
>>  target-ppc/translate/vmx-impl.inc.c |  2 ++
>>  target-ppc/translate/vmx-ops.inc.c  |  2 ++
>>  4 files changed, 18 insertions(+)
>> 
>> diff --git a/target-ppc/helper.h b/target-ppc/helper.h
>> index 04c6421..5fcc546 100644
>> --- a/target-ppc/helper.h
>> +++ b/target-ppc/helper.h
>> @@ -272,6 +272,8 @@ DEF_HELPER_2(vextsh2w, void, avr, avr)
>>  DEF_HELPER_2(vextsb2d, void, avr, avr)
>>  DEF_HELPER_2(vextsh2d, void, avr, avr)
>>  DEF_HELPER_2(vextsw2d, void, avr, avr)
>> +DEF_HELPER_2(vnegw, void, avr, avr)
>> +DEF_HELPER_2(vnegd, void, avr, avr)
>>  DEF_HELPER_2(vupkhpx, void, avr, avr)
>>  DEF_HELPER_2(vupklpx, void, avr, avr)
>>  DEF_HELPER_2(vupkhsb, void, avr, avr)
>> diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c
>> index 5aee0a8..7446e4e 100644
>> --- a/target-ppc/int_helper.c
>> +++ b/target-ppc/int_helper.c
>> @@ -1949,6 +1949,18 @@ VEXT_SIGNED(vextsh2d, s64, UINT16_MAX, int16_t, 
>> int64_t)
>>  VEXT_SIGNED(vextsw2d, s64, UINT32_MAX, int32_t, int64_t)
>>  #undef VEXT_SIGNED
>>  
>> +#define VNEG(name, element, mask)                                   \
>
> The mask parameter appears to be unused.

Yes, will remove it and send the updated patch.

Regards
Nikunj