[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 18/18] target-s390x: Use the new deposit and extr
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v2 18/18] target-s390x: Use the new deposit and extract ops |
Date: |
Tue, 18 Oct 2016 08:10:31 -0700 |
Use the new primitives for RISBG.
Signed-off-by: Richard Henderson <address@hidden>
---
target-s390x/translate.c | 34 ++++++++++++++++++++++------------
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/target-s390x/translate.c b/target-s390x/translate.c
index 02bc705..6cebb7e 100644
--- a/target-s390x/translate.c
+++ b/target-s390x/translate.c
@@ -3134,20 +3134,26 @@ static ExitStatus op_risbg(DisasContext *s, DisasOps *o)
}
}
- /* In some cases we can implement this with deposit, which can be more
- efficient on some hosts. */
- if (~mask == imask && i3 <= i4) {
- if (s->fields->op2 == 0x5d) {
- i3 += 32, i4 += 32;
- }
+ len = i4 - i3 + 1;
+ pos = 63 - i4;
+ rot = i5 & 63;
+ if (s->fields->op2 == 0x5d) {
+ pos += 32;
+ }
+
+ /* In some cases we can implement this with extract. */
+ if (imask == 0 && pos == 0 && len > 0 && rot + len <= 64) {
+ tcg_gen_extract_i64(o->out, o->in2, rot, len);
+ return NO_EXIT;
+ }
+
+ /* In some cases we can implement this with deposit. */
+ if (len > 0 && (imask == 0 || ~mask == imask)) {
/* Note that we rotate the bits to be inserted to the lsb, not to
the position as described in the PoO. */
- len = i4 - i3 + 1;
- pos = 63 - i4;
- rot = (i5 - pos) & 63;
+ rot = (rot - pos) & 63;
} else {
- pos = len = -1;
- rot = i5 & 63;
+ pos = -1;
}
/* Rotate the input as necessary. */
@@ -3155,7 +3161,11 @@ static ExitStatus op_risbg(DisasContext *s, DisasOps *o)
/* Insert the selected bits into the output. */
if (pos >= 0) {
- tcg_gen_deposit_i64(o->out, o->out, o->in2, pos, len);
+ if (imask == 0) {
+ tcg_gen_deposit_z_i64(o->out, o->in2, pos, len);
+ } else {
+ tcg_gen_deposit_i64(o->out, o->out, o->in2, pos, len);
+ }
} else if (imask == 0) {
tcg_gen_andi_i64(o->out, o->in2, mask);
} else {
--
2.7.4
- Re: [Qemu-devel] [PATCH v2 04/18] tcg/aarch64: Implement field extraction opcodes, (continued)
- [Qemu-devel] [PATCH v2 01/18] tcg: Add field extraction primitives, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 09/18] tcg/ppc: Implement field extraction opcodes, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 06/18] tcg/arm: Implement field extraction opcodes, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 10/18] tcg/s390: Expose host facilities to tcg-target.h, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 16/18] target-mips: Use the new extract op, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 14/18] target-arm: Use new deposit and extract ops, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 12/18] tcg/s390: Support deposit into zero, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 13/18] target-alpha: Use deposit and extract ops, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 18/18] target-s390x: Use the new deposit and extract ops,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 08/18] tcg/mips: Implement field extraction opcodes, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 11/18] tcg/s390: Implement field extraction opcodes, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 17/18] target-ppc: Use the new deposit and extract ops, Richard Henderson, 2016/10/18
- [Qemu-devel] [PATCH v2 15/18] target-i386: Use new deposit and extract ops, Richard Henderson, 2016/10/18
- Re: [Qemu-devel] [PATCH v2 00/18] tcg field extract primitives, no-reply, 2016/10/18
- Re: [Qemu-devel] [PATCH v2 00/18] tcg field extract primitives, Richard Henderson, 2016/10/24