[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH/RFC] vl: add no-panic option
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH/RFC] vl: add no-panic option |
Date: |
Mon, 17 Oct 2016 19:17:05 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Christian Borntraeger <address@hidden> writes:
> Some testcase will trigger a guest panic state. For testing purposes
> it can be useful to exit QEMU anyway.
>
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
> qemu-options.hx | 9 +++++++++
> vl.c | 6 ++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 01f01df..ee6d3d0 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -3301,6 +3301,15 @@ This allows for instance switching to monitor to
> commit changes to the
> disk image.
> ETEXI
>
> +DEF("no-panic", 0, QEMU_OPTION_no_panic, \
> + "-no-panic exit QEMU also in guest panic state\n", QEMU_ARCH_ALL)
> +STEXI
> address@hidden -no-panic
> address@hidden -no-panic
> +Exit QEMU on guest panic instead of keeping it alive. This allows for
> +instance running tests that are known to panic at the end.
> +ETEXI
> +
> DEF("loadvm", HAS_ARG, QEMU_OPTION_loadvm, \
> "-loadvm [tag|id]\n" \
> " start right away with a saved state (loadvm in
> monitor)\n",
Thank you for adding QEMU's 139-th option. Are you sure it needs to be
an option of its own, and can't be added to an existing QemuOpts option
group?