Re: [Qemu-devel] [PULL 00/22] linux-user changes

[Peter Maydell]

On 17 October 2016 at 14:24,  <address@hidden> wrote:
> From: Riku Voipio <address@hidden>
>
> The following changes since commit 7bf59dfec4234e75e31b3f397374cb5bab1a5b2c:
>
>   Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.8-20161017' 
> into staging (2016-10-17 12:59:54 +0100)
>
> are available in the git repository at:
>
>   git://git.linaro.org/people/riku.voipio/qemu.git 
> tags/pull-linux-user-20161017
>
> for you to fetch changes up to f2dbe98d6668b5ef98717410129098981e5df520:
>
>   linux-user: disable unicore32 linux-user build (2016-10-17 16:13:54 +0300)
>
> ----------------------------------------------------------------
> Linux-user pull request for October 2017
>
> ----------------------------------------------------------------

Couple of build failures, I'm afraid:

  CC      aarch64-linux-user/linux-user/syscall.o
/home/petmay01/linaro/qemu-for-merges/linux-user/syscall.c:9384:25:
error: variable 'ret' is used uninitialized whenever 'if' condition is
true [-Werror,-Wsometimes-uninitialized]
                    if (len == 0) {
                        ^~~~~~~~
/home/petmay01/linaro/qemu-for-merges/linux-user/syscall.c:12190:44:
note: uninitialized use occurs here
    trace_guest_user_syscall_ret(cpu, num, ret);
                                           ^~~
/home/petmay01/linaro/qemu-for-merges/linux-user/syscall.c:9384:21:
note: remove the 'if' if its condition is always false
                    if (len == 0) {
                    ^~~~~~~~~~~~~~~
/home/petmay01/linaro/qemu-for-merges/linux-user/syscall.c:7532:17:
note: initialize the variable 'ret' to silence this warning
    abi_long ret;
                ^
                 = 0
1 error generated.

(clang build)

and on AArch64 host, a linker warning which doesn't
break the build but is kind of noisy since it shows
up for every linux-user target:

/home/petmay01/qemu/linux-user/syscall.c:8260: warning: ustat is not
implemented and will always fail

We should probably be implementing ustat in terms of
statvfs().

thanks
-- PMM