[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] machine: Register TYPE_MACHINE properties a
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] machine: Register TYPE_MACHINE properties as class properties |
Date: |
Fri, 14 Oct 2016 10:24:25 -0300 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Fri, Oct 14, 2016 at 03:08:30PM +0200, Igor Mammedov wrote:
> On Thu, 13 Oct 2016 18:26:39 -0300
> Eduardo Habkost <address@hidden> wrote:
>
> > When doing the conversion, the NULL errp arguments on the
> > property registration calls were changed to &error_abort.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> So many property registrations look pretty ugly but still
> better than doing it per instance, not that it matters
> so far as there is only 1 instance of Machine at a time.
>
> So
> Reviewed-by: Igor Mammedov <address@hidden>
Thanks!
>
> most of the properties below are dumb field setter/getter,
> it would be much better to declare them statically and
> make generic Object code to initialize them at type
> initialization time.
> i.e. make similar thing like static properties but for class
> and probably extend it to have optional custom setter/getter.
I've been considering doing that. It should be easier after the
"qdev class properties" series gets applied, but the existing
static-property code is still specific to DeviceState (probably
it's only because the static property getter/setters include a
dev->realized check).
--
Eduardo
- [Qemu-devel] [PATCH 0/4] machine, hostmem, pc: Register properties as class properties, Eduardo Habkost, 2016/10/13
- [Qemu-devel] [PATCH 1/4] machine: Register TYPE_MACHINE properties as class properties, Eduardo Habkost, 2016/10/13
- [Qemu-devel] [PATCH 2/4] pc: Register TYPE_PC_MACHINE properties as class properties, Eduardo Habkost, 2016/10/13
- [Qemu-devel] [PATCH 3/4] hostmem: Register TYPE_MEMORY_BACKEND properties as class properties, Eduardo Habkost, 2016/10/13
- [Qemu-devel] [PATCH 4/4] hostmem-file: Register TYPE_MEMORY_BACKEND_FILE properties as class properties, Eduardo Habkost, 2016/10/13
- Re: [Qemu-devel] [PATCH 0/4] machine, hostmem, pc: Register properties as class properties, no-reply, 2016/10/13
- Re: [Qemu-devel] [PATCH 0/4] machine, hostmem, pc: Register properties as class properties, Eduardo Habkost, 2016/10/14