[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names |
Date: |
Thu, 13 Oct 2016 12:36:48 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/13/2016 11:44 AM, Markus Armbruster wrote:
> machine_set_property() replaces '_' by '-' in the property name.
> Except it fails to replace an initial '_'. Screwed up in commit
> b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property
> '._-foo-bar' not found".
>
> Error messages using a mangled name rather than the name the user
> actually wrote is user-hostile, but that's a different topic.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> vl.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names, Eduardo Habkost, 2016/10/13