[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 5/5] linux-user: Fix fadvise64() syscall support
From: |
Aleksandar Markovic |
Subject: |
[Qemu-devel] [PATCH v3 5/5] linux-user: Fix fadvise64() syscall support for Mips32 |
Date: |
Wed, 12 Oct 2016 14:30:25 +0200 |
From: Aleksandar Markovic <address@hidden>
By looking at the file arch/mips/kernel/scall32-o32.S in Linux
kernel, it can be deduced that, for Mips32 platform, syscall
corresponding to number _NR_fadvise64 as defined in kernel file
arch/mips/include/uapi/asm/unistd.h translates to kernel function
sys_fadvise64_64, and that argument layout for this system call is
as follows:
0 32 0 32
+----------------+----------------+
(arg1) | fd | __pad | (arg2)
+----------------+----------------+
(arg3) | buffer | (arg4)
+----------------+----------------+
(arg5) | len | (arg6)
+----------------+----------------+
(arg7) | advise | not used | (arg8)
+----------------+----------------+
The same argument layout can be deduced from glibc code, and
relevant commit messages in linux kernel and glibc.
The fix is to change TARGET_NR_fadvise64 to TARGET_NR_fadvise64_64
in Mips32 syscall numbers table. Array mips_syscall_args[] in
linux-user/main.c also already have "fadvise64_64" (and not
"fadvise64") in corresponding place for the syscall number in
question, so no change for linux-user/main.c.
This patch also fixes the failure LTP test posix_fadvise03, if
executed on Qemu-emulated Mips32 platform (user mode).
Signed-off-by: Aleksandar Rikalo <address@hidden>
Signed-off-by: Miroslav Tisma <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
---
linux-user/mips/syscall_nr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/mips/syscall_nr.h b/linux-user/mips/syscall_nr.h
index 8681558..299b6dd 100644
--- a/linux-user/mips/syscall_nr.h
+++ b/linux-user/mips/syscall_nr.h
@@ -256,7 +256,7 @@
#define TARGET_NR_remap_file_pages (TARGET_NR_Linux + 251)
#define TARGET_NR_set_tid_address (TARGET_NR_Linux + 252)
#define TARGET_NR_restart_syscall (TARGET_NR_Linux + 253)
-#define TARGET_NR_fadvise64 (TARGET_NR_Linux + 254)
+#define TARGET_NR_fadvise64_64 (TARGET_NR_Linux + 254)
#define TARGET_NR_statfs64 (TARGET_NR_Linux + 255)
#define TARGET_NR_fstatfs64 (TARGET_NR_Linux + 256)
#define TARGET_NR_timer_create (TARGET_NR_Linux + 257)
--
2.9.3
- [Qemu-devel] [PATCH v2 1/5] linux-user: Update syscall numbers tables for Mips, (continued)
- [Qemu-devel] [PATCH v2 1/5] linux-user: Update syscall numbers tables for Mips, Aleksandar Markovic, 2016/10/12
- [Qemu-devel] [PATCH v2 3/5] linux-user: Update ioctls definitions for Mips32, Aleksandar Markovic, 2016/10/12
- [Qemu-devel] [PATCH v2 2/5] linux-user: Update mips_syscall_args[] array in main.c, Aleksandar Markovic, 2016/10/12
- [Qemu-devel] [PATCH v2 4/5] linux-user: Redirect termbits.h for Mips64 to termbits.h for Mips32, Aleksandar Markovic, 2016/10/12
- [Qemu-devel] [PATCH v2 5/5] linux-user: Fix fadvise64() syscall support for Mips32, Aleksandar Markovic, 2016/10/12
- [Qemu-devel] [PATCH v2 0/5] linux-user: Several Mips-related patches, Aleksandar Markovic, 2016/10/12
- [Qemu-devel] [PATCH v3 1/5] linux-user: Update syscall numbers tables for Mips, Aleksandar Markovic, 2016/10/12
- [Qemu-devel] [PATCH v3 3/5] linux-user: Update ioctls definitions for Mips32, Aleksandar Markovic, 2016/10/12
- [Qemu-devel] [PATCH v3 2/5] linux-user: Update mips_syscall_args[] array in main.c, Aleksandar Markovic, 2016/10/12
- [Qemu-devel] [PATCH v3 5/5] linux-user: Fix fadvise64() syscall support for Mips32,
Aleksandar Markovic <=
- [Qemu-devel] [PATCH v3 4/5] linux-user: Redirect termbits.h for Mips64 to termbits.h for Mips32, Aleksandar Markovic, 2016/10/12
- Re: [Qemu-devel] [PATCH v2 0/5] linux-user: Several Mips-related patches, Riku Voipio, 2016/10/17