[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH |
Date: |
Wed, 12 Oct 2016 10:43:03 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 12.10.2016 um 10:37 hat Ashijeet Acharya geschrieben:
> On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf <address@hidden> wrote:
> > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben:
>
> > Of course, we must be able to build qemu correctly both with ssh enabled
> > and disabled, so if you can indeed see a (different) build error with
> > disabled libssh2, that needs to be fixed.
>
> I am able to reproduce it when I don't apply Dan's patch with libssh2 enabled.
> After disabling libssh2, it compiles perfectly because then the SSH
> driver will get ignored I guess.
> libssh2 doesn't seem to be the problem.
>
> >
> > But I can't see how that would happen, you don't touch configure and it
> > already compiled the ssh driver out if libssh2 is disabled.
>
> Yes, with libssh2 disabled it builds with no error just like the first
> output of auto-build shows.
> So, I think with libssh2 enabled it throws an error (just like second
> output of auto-build) since Dan's patches are not merged yet. Right?
Yes. You can ignore that, we'll make sure to merge the patches in the
right order.
Kevin
- [Qemu-devel] [PATCH 1/4] block/ssh: Add ssh_has_filename_options_conflict(), (continued)
- [Qemu-devel] [PATCH 1/4] block/ssh: Add ssh_has_filename_options_conflict(), Ashijeet Acharya, 2016/10/11
- [Qemu-devel] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it, Ashijeet Acharya, 2016/10/11
- [Qemu-devel] [PATCH 3/4] block/ssh: Use InetSocketAddress options, Ashijeet Acharya, 2016/10/11
- [Qemu-devel] [PATCH 4/4] qapi: allow blockdev-add for ssh, Ashijeet Acharya, 2016/10/11
- Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH, no-reply, 2016/10/11
- Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH, Ashijeet Acharya, 2016/10/12
- Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH, Ashijeet Acharya, 2016/10/12
- Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH, Kevin Wolf, 2016/10/12