[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/intc/arm_gic_kvm: Fix build on aarch64
From: |
Christopher Covington |
Subject: |
Re: [Qemu-devel] [PATCH] hw/intc/arm_gic_kvm: Fix build on aarch64 |
Date: |
Tue, 11 Oct 2016 13:08:01 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 |
On 10/11/2016 12:43 PM, Peter Maydell wrote:
> On 11 October 2016 at 17:32, Christopher Covington <address@hidden> wrote:
>> Remove unused debugging code to fix native building on aarch64. Without
>> this change, the following -Werr output inhibits make from completing.
>>
>> qemu/hw/intc/arm_gic_kvm.c:38:18: error: debug_gic_kvm defined but not
>> used [-Werror=unused-const-variable=]
>> static const int debug_gic_kvm = 0;
>> ^~~~~~~~~~~~~
>> cc1: all warnings being treated as errors
>> qemu/rules.mak:60: recipe for target 'hw/intc/arm_gic_kvm.o' failed
>> make[1]: *** [hw/intc/arm_gic_kvm.o] Error 1
>> Makefile:205: recipe for target 'subdir-aarch64-softmmu' failed
>
> This builds for me on aarch64, so presumably this is a "newer
> compiler is more picky" warning.
>From Fedora 25:
gcc (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)
> In any case, since we don't use the DPRINTF macro we may as well
> dump it (we should use tracepoints if we want to add interesting
> debug-logging in future anyhow).
>
> Reviewed-by: Peter Maydell <address@hidden>
Thanks Peter!
Cov
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code
Aurora Forum, a Linux Foundation Collaborative Project.