Re: [Qemu-devel] [PATCH v5 13/35] tcg: Add atomic helpers

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> On 10/11/2016 01:47 AM, Alex Bennée wrote:
>>
>> Richard Henderson <address@hidden> writes:
>>
>>> Add all of cmpxchg, op_fetch, fetch_op, and xchg.
>>> Handle both endian-ness, and sizes up to 8.
>>> Handle expanding non-atomically, when emulating in serial.
>>>
>>> Signed-off-by: Richard Henderson <address@hidden>
>>
>> This still seems to be suffering expansion problems on Travis:
>
> I must be losing my mind.
>
>>>  include/qemu/atomic.h |  19 ++-
>
> I can tell at a glance that this is, for a second time, missing a patch that I
> know I applied twice.  Indeed, going back to look at the rest of the series,
> it's missing 4 other changes.
>
> Ho hum.  I'll prepare a v6, I suppose.

Do you keep change notes under --- in your commits and then strip them
off for review/posting? Is this just using plain git tools or one of the
porcelain layers?

>
>
> r~


--
Alex Bennée