[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass |
Date: |
Tue, 11 Oct 2016 07:50:50 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Oct 10, 2016 at 03:35:26PM +0200, Radim Krčmář wrote:
[...]
> Yes, but it is a separate logical change, so I'd do that in a separate
> cleaup patch that amends it in the whole file ...
> (And I prefer to copy-paste code verbatim.)
Sure.
>
> > And, this patch is assuming MSIMessage as host endianess (which is
> > good to me). Not sure whether we need fixes for the whole MSIMessage
> > cleanup (after all, kvm_irqchip_send_msi() is taking it as LE). Or we
> > can do it afterwards since it won't break anything AFAIU.
>
> This patch doesn't affect existing callers, and IR known to be broken,
> so I think we can sort endianess out later ...
Agree. Patch:
[PATCH] Revert "KVM: MSI: Swap payload to native endianness"
is for the cleanup actually. Though I am not sure whether that's
enough and correct. Looking forward to any review comments.
Thanks,
-- peterx
Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic, Peter Xu, 2016/10/08