Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines

[Richard Henderson]

On 10/01/2016 05:05 AM, Artyom Tarasenko wrote:
>  #define TTE_VALID_BIT       (1ULL << 63)
>  #define TTE_NFO_BIT         (1ULL << 60)
> +#define TTE_NFO_BIT_UA2005  (1ULL << 62)
>  #define TTE_USED_BIT        (1ULL << 41)
> +#define TTE_USED_BIT_UA2005 (1ULL << 47)
>  #define TTE_LOCKED_BIT      (1ULL <<  6)
> +#define TTE_LOCKED_BIT_UA2005 (1ULL <<  61)
>  #define TTE_SIDEEFFECT_BIT  (1ULL <<  3)
> +#define TTE_SIDEEFFECT_BIT_UA2005 (1ULL <<  11)
>  #define TTE_PRIV_BIT        (1ULL <<  2)
> +#define TTE_PRIV_BIT_UA2005 (1ULL <<  8)
>  #define TTE_W_OK_BIT        (1ULL <<  1)
> +#define TTE_W_OK_BIT_UA2005 (1ULL <<  6)
>  #define TTE_GLOBAL_BIT      (1ULL <<  0)

Hmm.  Would it make more sense to reorg these as

  TTE_US1_*
  TTE_UA2005_*

with some duplication for the bits that are shared?
As is, it's pretty hard to tell which actually change...


r~