Re: [Qemu-devel] [PATCH] qtest: ask endianness of the target in qtest_init()

[David Gibson]

On Fri, Oct 07, 2016 at 12:10:07PM +0200, Greg Kurz wrote:
> On Fri, 7 Oct 2016 10:39:09 +0100
> Peter Maydell <address@hidden> wrote:
> 
> > On 7 October 2016 at 00:55, David Gibson <address@hidden> wrote:
> > > It is an improvement.  But I still think if we're relying on the
> > > ill-defined "target endianness" we're already doing something wrong.  
> > 
> > Target endianness is not ill-defined. It's a clear and constant
> > property of the bus the CPU is plugged into. It is a bit weird
> > to rely on it in the test code, which is why only the virtio
> > tests currently use qtest_big_endian().
> > 
> 
> And to discourage anyone to use it in a test program, maybe it
> could even be renamed virtio_big_endian() and put in a virtio
> specific header file ? This is how it is done in QEMU.

I think that's a good idea.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature