Re: [Qemu-devel] [PATCH 2/2] tests: use accel=best instead of accel=kvm:tcg

[Michael S. Tsirkin]

On Tue, Oct 04, 2016 at 01:30:48PM +0200, Laurent Vivier wrote:
> This avoids to have logs polluted by "kvm accelerator not found".
> 
> Signed-off-by: Laurent Vivier <address@hidden>


Acked-by: Michael S. Tsirkin <address@hidden>


> ---
>  tests/bios-tables-test.c | 2 +-
>  tests/postcopy-test.c    | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index 7e27ea9..497dd56 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -716,7 +716,7 @@ static void test_acpi_one(const char *params, test_data 
> *data)
>                             "-net none -display none %s "
>                             "-drive id=hd0,if=none,file=%s,format=raw "
>                             "-device ide-hd,drive=hd0 ",
> -                           data->machine, "kvm:tcg",
> +                           data->machine, "best",
>                             params ? params : "", disk);
>  
>      qtest_start(args);
> diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
> index 41ed1a9..d549d5e 100644
> --- a/tests/postcopy-test.c
> +++ b/tests/postcopy-test.c
> @@ -368,12 +368,12 @@ static void test_migrate(void)
>  
>      if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
>          init_bootfile_x86(bootpath);
> -        cmd_src = g_strdup_printf("-machine accel=kvm:tcg -m 150M"
> +        cmd_src = g_strdup_printf("-machine accel=best -m 150M"
>                                    " -name pcsource,debug-threads=on"
>                                    " -serial file:%s/src_serial"
>                                    " -drive file=%s,format=raw",
>                                    tmpfs, bootpath);
> -        cmd_dst = g_strdup_printf("-machine accel=kvm:tcg -m 150M"
> +        cmd_dst = g_strdup_printf("-machine accel=best -m 150M"
>                                    " -name pcdest,debug-threads=on"
>                                    " -serial file:%s/dest_serial"
>                                    " -drive file=%s,format=raw"
> @@ -381,12 +381,12 @@ static void test_migrate(void)
>                                    tmpfs, bootpath, uri);
>      } else if (strcmp(arch, "ppc64") == 0) {
>          init_bootfile_ppc(bootpath);
> -        cmd_src = g_strdup_printf("-machine accel=kvm:tcg -m 256M"
> +        cmd_src = g_strdup_printf("-machine accel=best -m 256M"
>                                    " -name pcsource,debug-threads=on"
>                                    " -serial file:%s/src_serial"
>                                    " -drive file=%s,if=pflash,format=raw",
>                                    tmpfs, bootpath);
> -        cmd_dst = g_strdup_printf("-machine accel=kvm:tcg -m 256M"
> +        cmd_dst = g_strdup_printf("-machine accel=best -m 256M"
>                                    " -name pcdest,debug-threads=on"
>                                    " -serial file:%s/dest_serial"
>                                    " -incoming %s",
> -- 
> 2.7.4