Re: [Qemu-devel] [PATCH] net: eepro100: fix memory leak in device uninit

[Li Qiang]

Hello Stefan,

I'm not familiar with the migration. In order not miss something, I think
you can provide this patch.

Thanks.

2016-10-09 0:43 GMT+08:00 Stefan Weil <address@hidden>:

> Am 08.10.2016 um 18:19 schrieb Stefan Weil:
>
>> Am 08.10.2016 um 14:07 schrieb Li Qiang:
>>
>>> From: Li Qiang <address@hidden>
>>>
>>> The exit dispatch of eepro100 network card device doesn't free
>>> the 's->vmstate' field which was allocated in device realize thus
>>> leading a host memory leak. This patch avoid this.
>>>
>>> Signed-off-by: Li Qiang <address@hidden>
>>>
>>
>> Thank you for reporting this memory leak.
>>
>> I think that an even better solution would be avoiding the dynamic
>> memory allocation. We could use this declaration for example:
>>
>>     /* vmstate for each particular nic */
>>     VMStateDescription vmstate;
>>
>> Do you want to prepare a new patch, or should I do it?
>>
>
> While thinking more about it, the solution used for e1000 looks better:
> vmstate could be a static const object, and the name field would always be
> "e100", no matter which specific nic was chosen.
>
> Stefan
>
>