qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 4/8] intel_iommu: redo configuraton check in


From: Peter Xu
Subject: Re: [Qemu-devel] [PATCH v4 4/8] intel_iommu: redo configuraton check in realize
Date: Sat, 8 Oct 2016 14:45:38 +0800
User-agent: Mutt/1.5.24 (2015-08-30)

On Wed, Oct 05, 2016 at 03:06:53PM +0200, Radim Krčmář wrote:
> * there no point in configuring the device if realization is going to
>   fail, so move the check to the beginning,
> * create a separate function for the check,
> * use error_setg() instead error_report().
> 
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: Radim Krčmář <address@hidden>

Reviewed-by: Peter Xu <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]