Re: [Qemu-devel] [PULL 00/20] Tracing patches

[Peter Maydell]

On 7 October 2016 at 14:46, Lluís Vilanova <address@hidden> wrote:
> diff --git a/qom/cpu.c b/qom/cpu.c
> index 484c493..40f2eb1 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -356,12 +356,15 @@ static void cpu_common_initfn(Object *obj)
>      qemu_mutex_init(&cpu->work_mutex);
>      QTAILQ_INIT(&cpu->breakpoints);
>      QTAILQ_INIT(&cpu->watchpoints);
> -    bitmap_zero(cpu->trace_dstate, TRACE_VCPU_EVENT_COUNT);
> +
> +    cpu->trace_dstate = bitmap_new(min(trace_get_vcpu_event_count(), 1);
>  }
>
>  static void cpu_common_finalize(Object *obj)
>  {
> -    cpu_exec_exit(CPU(obj));
> +    CPUState *cpu = CPU(obj);
> +    cpu_exec_exit(cpu);
> +    g_free(cpu->trace_dstate);
>  }
>
>  static int64_t cpu_common_get_arch_id(CPUState *cpu)
>
> Beware that min() needs to be defined somewhere on that file first (should it 
> be
> available on some generic header?).

osdep.h defines a MIN() macro.

thanks
-- PMM