Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

[Peter Maydell]

On 6 October 2016 at 16:36, Paolo Bonzini <address@hidden> wrote:
>
>
> On 06/10/2016 16:11, Greg Kurz wrote:
>> FWIW, Cedric had another proposal which apparently went unnoticed:
>>
>> <address@hidden>
>>
>> The idea is to add an optional endianness argument to the read*/write*
>> commands in the qtest protocol:
>> - libqtest then provides explicit _le and _be APIs
>> - no extra byteswap is performed on the test program side: qtest
>>   actually handles that and does exactly 1 or 0 byteswap.
>> - it does not use memread/memwrite
>> - the current 'guest native' API where qtest tswaps is preserved
>>
>
> No, this is a worse idea, because the right place to do the swap is in
> the "program" (libqtest) not in the "CPU" (QEMU).

Speaking of the right place to do things, perhaps we should
reimplement qtest_big_endian() in libqtest.c to send a query
to the QEMU-under-test to ask it what TARGET_BIG_ENDIAN says,
rather than hardcoding a big list of architectures...

thanks
-- PMM