Re: [Qemu-devel] [PATCH 0/3] qht fixes

[Dr. David Alan Gilbert]

* Emilio G. Cota (address@hidden) wrote:
> Patch 1 fixes a warning that gcc may unnecessarily emit.
> 
> Patch 2 fixes a real bug that sometimes shows up as a segfault in test-qht.
> Daniel reported it yesterday on IRC; the trick to easily trigger it is to
> run on RHEL6 (or CentOS6).
> It is very likely that this is the test-qht failure that Peter reported here:
>   https://lists.nongnu.org/archive/html/qemu-devel/2016-08/msg03771.html
> (we cannot be 100% sure due to the lack of output there; however the fact that
> it's the resize what fails supports the hypothesis that we're indeed hitting 
> the
> same bug.)
> I'm therefore adding Peter's reported-by tag to the patch along with Daniel's.
> 
> Patch 3 is merely good practice, since test-qht is single-threaded. However
> I like having it, since test-qht serves as a de facto usage example
> of qht.
> 
> Given that patch 2 alone would conflict without previously applying patch 1,
> I propose to merge both patches 1 & 2 to 2.7-stable. I'll send them to
> qemu-stable once the patchset is picked up to be merged onto master.

That seems to fix the tests-qht failure I was seeing on RHEL6.

Dave

> Thanks,
> 
>               Emilio
> 
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK